Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable swiping in some extra cases [WPB-9044] #2983

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented May 7, 2024

BugWPB-9044 [Android] Fix multiple replying issues


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. Messages in search results and gallery are swipable to reply. And they definitely shouldn't.
  2. Deleted messages are a swipable to reply.
  3. Self-deleting messages show a slight indication that swiping is possible.

Causes

SadSorryGIF

Also, Compose's SwipeToDismissBox shows a small indication that the item is swipable even when it is disabled.

Solutions

Replace the onSwipeToReply lambda with a SwipableMessageConfiguration sealed interface, that can be either enabled or disabled.

And completely avoid drawing a SwipeToDismissBox when the message shouldn't be swipable.

Testing

Manually tested

How to Test

  1. Go to conv details, search for stuff and try to swipe.
  2. Go to conv details, see the gallery and try to swipe.

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👌🏻

@vitorhugods vitorhugods changed the title fix: disable swiping in search results and gallery [WPB-9044] fix: disable swiping in some extra cases [WPB-9044] May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Test Results

927 tests   927 ✅  17m 32s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit d349ef0.

Copy link
Contributor

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4658 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 0fff668 into release/candidate May 7, 2024
16 checks passed
@vitorhugods vitorhugods deleted the fix/swipable-search-results-and-media-gallery branch May 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants